DOM: support onClose event in dialog element#55
DOM: support onClose event in dialog element#55pete-murphy merged 2 commits intopurescript-react:mainfrom
onClose event in dialog element#55Conversation
|
Hi, thanks for the PR! The |
Thank you, sure! But how do I regenerate the "Generated.pus" file afterwards? In fact, I've seen that the file is generated, but I waited for someone to suggest how to make the proper change, because the header of the file has no mention how would one generate it 😅 |
|
Looks like you should be able to do |
84a704c to
19b0082
Compare
|
@pete-murphy thank you, done! I also made a commit that adds an explanation to the header about how to regenerate files, so in the future hopefully contributions from new users will be simpler 😊 Please review |
|
Thanks again! Released as part of Updating the registry here: purescript/registry#501 |
|
@pete-murphy oh, thank you! But what do you think about this suggestion? Would be cool to have it included as well 😊 |
See: https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/close_event